Skip to content

Conversation

@kikkia
Copy link

@kikkia kikkia commented Oct 20, 2025

This reverts commit d64e677.

Related GitHub Issue

Closes: #

Roo Code Task Context (Optional)

Description

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

@kikkia kikkia requested review from cte, jr and mrubens as code owners October 20, 2025 17:35
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 20, 2025
@kikkia kikkia closed this Oct 20, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Oct 20, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Oct 20, 2025
@roomote
Copy link

roomote bot commented Oct 20, 2025

Review Summary

Found duplicate schema entries that need to be removed:

  • Remove duplicate geminiCliSchema entry in providerSettingsSchemaDiscriminated (line 432)
  • Remove duplicate geminiCliSchema.shape entry in providerSettingsSchema (line 474)

These duplicates were introduced during the revert and should be cleaned up to avoid redundancy in the schema definitions.

@kikkia
Copy link
Author

kikkia commented Oct 20, 2025

Meant for my fork, sorry

lmStudioSchema.merge(z.object({ apiProvider: z.literal("lmstudio") })),
geminiSchema.merge(z.object({ apiProvider: z.literal("gemini") })),
geminiCliSchema.merge(z.object({ apiProvider: z.literal("gemini-cli") })),
geminiCliSchema.merge(z.object({ apiProvider: z.literal("gemini-cli") })),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate schema entry. The geminiCliSchema is added twice here, which is redundant. Remove one of the duplicate lines.

...lmStudioSchema.shape,
...geminiSchema.shape,
...geminiCliSchema.shape,
...geminiCliSchema.shape,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate schema entry. The geminiCliSchema.shape is added twice here, which is redundant. Remove one of the duplicate lines.

@kikkia kikkia changed the title Revert "Remove Gemini CLI provider (#5223)" test Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant